scsi: megaraid: Fix ifnullfree.cocci warnings

intel-lab-lkp · martinkpetersen · commit 12e3ef8b3e7c · 2021-01-22T22:24:44.000-05:00
NULL check before vfree is not needed. Generated by: scripts/coccinelle/free/ifnullfree.cocci Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2012111113060.2669@hadrien Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3920,8 +3920,7 @@ megasas_free_host_crash_buffer(struct megasas_instance *instance)
 {
 	unsigned int i;
 	for (i = 0; i < instance->drv_buf_alloc; i++) {
-		if (instance->crash_buf[i])
-			vfree(instance->crash_buf[i]);
+		vfree(instance->crash_buf[i]);
 	}
 	instance->drv_buf_index = 0;
 	instance->drv_buf_alloc = 0;

Original file line number	Diff line number	Diff line change
`@@ -3920,8 +3920,7 @@ megasas_free_host_crash_buffer(struct megasas_instance *instance)`
`3920`	`3920`	`{`
`3921`	`3921`	`unsigned int i;`
`3922`	`3922`	`for (i = 0; i < instance->drv_buf_alloc; i++) {`
`3923`		`- if (instance->crash_buf[i])`
`3924`		`- vfree(instance->crash_buf[i]);`
	`3923`	`+ vfree(instance->crash_buf[i]);`
`3925`	`3924`	`}`
`3926`	`3925`	`instance->drv_buf_index = 0;`
`3927`	`3926`	`instance->drv_buf_alloc = 0;`