rtnetlink: change rtnl_stats_dump() return value

edumazet · kuba-moo · commit 136c2a9a2a87 · 2024-05-03T15:03:42.000-07:00
By returning 0 (or an error) instead of skb->len, we allow NLMSG_DONE to be appended to the current skb at the end of a dump, saving a couple of recvmsg() system calls. Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20240502113748.1622637-2-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
@@ -6024,7 +6024,7 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb)
 	cb->args[1] = idx;
 	cb->args[0] = h;
 
-	return skb->len;
+	return err;
 }
 
 void rtnl_offload_xstats_notify(struct net_device *dev)

Original file line number	Diff line number	Diff line change
`@@ -6024,7 +6024,7 @@ static int rtnl_stats_dump(struct sk_buff skb, struct netlink_callback cb)`
`6024`	`6024`	`cb->args[1] = idx;`
`6025`	`6025`	`cb->args[0] = h;`
`6026`	`6026`
`6027`		`- return skb->len;`
	`6027`	`+ return err;`
`6028`	`6028`	`}`
`6029`	`6029`
`6030`	`6030`	`void rtnl_offload_xstats_notify(struct net_device *dev)`