Skip to content

Commit 1373665

Browse files
namjaejeonsmfrench
authored andcommitted
ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2 specification is a typo. cifs/ksmbd have been using this wrong name from MS-SMB2. It should be "AlSi". Also It will cause problem when running smb2.create.open test in smbtorture against ksmbd. Cc: stable@vger.kernel.org Fixes: 12197a7 ("Clarify SMB2/SMB3 create context and add missing ones") Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent a9f106c commit 1373665

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/smb/common/smb2pdu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@ struct smb2_server_client_notification {
11451145
#define SMB2_CREATE_SD_BUFFER "SecD" /* security descriptor */
11461146
#define SMB2_CREATE_DURABLE_HANDLE_REQUEST "DHnQ"
11471147
#define SMB2_CREATE_DURABLE_HANDLE_RECONNECT "DHnC"
1148-
#define SMB2_CREATE_ALLOCATION_SIZE "AISi"
1148+
#define SMB2_CREATE_ALLOCATION_SIZE "AlSi"
11491149
#define SMB2_CREATE_QUERY_MAXIMAL_ACCESS_REQUEST "MxAc"
11501150
#define SMB2_CREATE_TIMEWARP_REQUEST "TWrp"
11511151
#define SMB2_CREATE_QUERY_ON_DISK_ID "QFid"

0 commit comments

Comments
 (0)