Skip to content

Commit 13a8aca

Browse files
committed
drm/i915: Move intel_hpd_poll_fini() into intel_hotplug.c
The name of intel_hpd_poll_fini() suggests that it should live in intel_hotplug.c. Make it so. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250213150220.13580-6-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent d9794af commit 13a8aca

4 files changed

Lines changed: 17 additions & 18 deletions

File tree

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
#include "intel_cdclk.h"
6464
#include "intel_clock_gating.h"
6565
#include "intel_color.h"
66-
#include "intel_connector.h"
6766
#include "intel_crt.h"
6867
#include "intel_crtc.h"
6968
#include "intel_crtc_state_dump.h"
@@ -93,7 +92,6 @@
9392
#include "intel_fdi.h"
9493
#include "intel_fifo_underrun.h"
9594
#include "intel_frontbuffer.h"
96-
#include "intel_hdcp.h"
9795
#include "intel_hdmi.h"
9896
#include "intel_hotplug.h"
9997
#include "intel_link_bw.h"
@@ -8538,20 +8536,6 @@ void i830_disable_pipe(struct intel_display *display, enum pipe pipe)
85388536
intel_de_posting_read(display, DPLL(display, pipe));
85398537
}
85408538

8541-
void intel_hpd_poll_fini(struct drm_i915_private *i915)
8542-
{
8543-
struct intel_connector *connector;
8544-
struct drm_connector_list_iter conn_iter;
8545-
8546-
/* Kill all the work that may have been queued by hpd. */
8547-
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
8548-
for_each_intel_connector_iter(connector, &conn_iter) {
8549-
intel_connector_cancel_modeset_retry_work(connector);
8550-
intel_hdcp_cancel_works(connector);
8551-
}
8552-
drm_connector_list_iter_end(&conn_iter);
8553-
}
8554-
85558539
bool intel_scanout_needs_vtd_wa(struct intel_display *display)
85568540
{
85578541
struct drm_i915_private *i915 = to_i915(display->drm);

drivers/gpu/drm/i915/display/intel_display.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -569,8 +569,6 @@ enum drm_mode_status intel_mode_valid(struct drm_device *dev,
569569
int intel_atomic_commit(struct drm_device *dev, struct drm_atomic_state *_state,
570570
bool nonblock);
571571

572-
void intel_hpd_poll_fini(struct drm_i915_private *i915);
573-
574572
/* modesetting asserts */
575573
void assert_transcoder(struct intel_display *display,
576574
enum transcoder cpu_transcoder, bool state);

drivers/gpu/drm/i915/display/intel_hotplug.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@
2828

2929
#include "i915_drv.h"
3030
#include "i915_irq.h"
31+
#include "intel_connector.h"
3132
#include "intel_display_power.h"
3233
#include "intel_display_types.h"
34+
#include "intel_hdcp.h"
3335
#include "intel_hotplug.h"
3436
#include "intel_hotplug_irq.h"
3537

@@ -864,6 +866,20 @@ void intel_hpd_poll_disable(struct drm_i915_private *dev_priv)
864866
spin_unlock_irq(&dev_priv->irq_lock);
865867
}
866868

869+
void intel_hpd_poll_fini(struct drm_i915_private *i915)
870+
{
871+
struct intel_connector *connector;
872+
struct drm_connector_list_iter conn_iter;
873+
874+
/* Kill all the work that may have been queued by hpd. */
875+
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
876+
for_each_intel_connector_iter(connector, &conn_iter) {
877+
intel_connector_cancel_modeset_retry_work(connector);
878+
intel_hdcp_cancel_works(connector);
879+
}
880+
drm_connector_list_iter_end(&conn_iter);
881+
}
882+
867883
void intel_hpd_init_early(struct drm_i915_private *i915)
868884
{
869885
INIT_DELAYED_WORK(&i915->display.hotplug.hotplug_work,

drivers/gpu/drm/i915/display/intel_hotplug.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ enum port;
1616

1717
void intel_hpd_poll_enable(struct drm_i915_private *dev_priv);
1818
void intel_hpd_poll_disable(struct drm_i915_private *dev_priv);
19+
void intel_hpd_poll_fini(struct drm_i915_private *i915);
1920
enum intel_hotplug_state intel_encoder_hotplug(struct intel_encoder *encoder,
2021
struct intel_connector *connector);
2122
void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,

0 commit comments

Comments
 (0)