Skip to content

Commit 144f1cd

Browse files
Qilin TanJaegeuk Kim
authored andcommitted
f2fs: fix iostat lock protection
Made iostat lock irq safe to avoid potentinal deadlock. Deadlock scenario: f2fs_attr_store -> f2fs_sbi_store -> _sbi_store -> spin_lock(sbi->iostat_lock) <interrupt request> -> scsi_end_request -> bio_endio -> f2fs_dio_read_end_io -> f2fs_update_iostat -> spin_lock_irqsave(sbi->iostat_lock) ===> Dead lock here Fixes: 61803e9 ("f2fs: fix iostat related lock protection") Fixes: a1e09b0 ("f2fs: use iomap for direct I/O") Signed-off-by: Qilin Tan <qilin.tan@mediatek.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent f26aaee commit 144f1cd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

fs/f2fs/sysfs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,9 +575,9 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
575575
if (!strcmp(a->attr.name, "iostat_period_ms")) {
576576
if (t < MIN_IOSTAT_PERIOD_MS || t > MAX_IOSTAT_PERIOD_MS)
577577
return -EINVAL;
578-
spin_lock(&sbi->iostat_lock);
578+
spin_lock_irq(&sbi->iostat_lock);
579579
sbi->iostat_period_ms = (unsigned int)t;
580-
spin_unlock(&sbi->iostat_lock);
580+
spin_unlock_irq(&sbi->iostat_lock);
581581
return count;
582582
}
583583
#endif

0 commit comments

Comments
 (0)