Skip to content

Commit 1453323

Browse files
Abhishek-Tamboli9superna9999
authored andcommitted
drm/panel: ili9341: Add comments for registers in ili9341_config()
Add detail comments for registers definitions in struct ili9341_config(). Replace TODO with comment for each registers. Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20240819175122.33176-1-abhishektamboli9@gmail.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240819175122.33176-1-abhishektamboli9@gmail.com
1 parent b61c4bc commit 1453323

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

drivers/gpu/drm/panel/panel-ilitek-ili9341.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,19 @@ struct ili9341_config {
121121
const struct drm_display_mode mode;
122122
/* ca: TODO: need comments for this register */
123123
u8 ca[ILI9341_CA_LEN];
124-
/* power_b: TODO: need comments for this register */
124+
/* power_b: Power control B (CFh) */
125125
u8 power_b[ILI9341_POWER_B_LEN];
126-
/* power_seq: TODO: need comments for this register */
126+
/* power_seq: Power on sequence control (EDh) */
127127
u8 power_seq[ILI9341_POWER_SEQ_LEN];
128-
/* dtca: TODO: need comments for this register */
128+
/* dtca: Driver timing control A (E8h) */
129129
u8 dtca[ILI9341_DTCA_LEN];
130-
/* dtcb: TODO: need comments for this register */
130+
/* dtcb: Driver timing control B (EAh) */
131131
u8 dtcb[ILI9341_DTCB_LEN];
132-
/* power_a: TODO: need comments for this register */
132+
/* power_a: Power control A (CBh) */
133133
u8 power_a[ILI9341_POWER_A_LEN];
134134
/* frc: Frame Rate Control (In Normal Mode/Full Colors) (B1h) */
135135
u8 frc[ILI9341_FRC_LEN];
136-
/* prc: TODO: need comments for this register */
136+
/* prc: Pump ratio control (F7h) */
137137
u8 prc;
138138
/* dfc_1: B6h DISCTRL (Display Function Control) */
139139
u8 dfc_1[ILI9341_DFC_1_LEN];
@@ -147,7 +147,7 @@ struct ili9341_config {
147147
u8 vcom_2;
148148
/* address_mode: Memory Access Control (36h) */
149149
u8 address_mode;
150-
/* g3amma_en: TODO: need comments for this register */
150+
/* g3amma_en: Enable 3G (F2h) */
151151
u8 g3amma_en;
152152
/* rgb_interface: RGB Interface Signal Control (B0h) */
153153
u8 rgb_interface;

0 commit comments

Comments
 (0)