Skip to content

Commit 145a417

Browse files
aloktiwarleon
authored andcommitted
RDMA/bnxt_re: Fix incorrect BAR check in bnxt_qplib_map_creq_db()
RCFW_COMM_CONS_PCI_BAR_REGION is defined as BAR 2, so checking !creq_db->reg.bar_id is incorrect and always false. pci_resource_start() returns the BAR base address, and a value of 0 indicates that the BAR is unassigned. Update the condition to test bar_base == 0 instead. This ensures the driver detects and logs an error for an unassigned RCFW communication BAR. Fixes: cee0c7b ("RDMA/bnxt_re: Refactor command queue management code") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Link: https://patch.msgid.link/20251217100158.752504-1-alok.a.tiwari@oracle.com Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent 8aaa848 commit 145a417

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ static int bnxt_qplib_map_creq_db(struct bnxt_qplib_rcfw *rcfw, u32 reg_offt)
11121112
creq_db->dbinfo.flags = 0;
11131113
creq_db->reg.bar_id = RCFW_COMM_CONS_PCI_BAR_REGION;
11141114
creq_db->reg.bar_base = pci_resource_start(pdev, creq_db->reg.bar_id);
1115-
if (!creq_db->reg.bar_id)
1115+
if (!creq_db->reg.bar_base)
11161116
dev_err(&pdev->dev,
11171117
"QPLIB: CREQ BAR region %d resc start is 0!",
11181118
creq_db->reg.bar_id);

0 commit comments

Comments
 (0)