Skip to content

Commit 148519a

Browse files
petrpavlusamitolvanen
authored andcommitted
module: Remove SHA-1 support for module signing
SHA-1 is considered deprecated and insecure due to vulnerabilities that can lead to hash collisions. Most distributions have already been using SHA-2 for module signing because of this. The default was also changed last year from SHA-1 to SHA-512 in commit f3b9354 ("module: sign with sha512 instead of sha1 by default"). This was not reported to cause any issues. Therefore, it now seems to be a good time to remove SHA-1 support for module signing. Commit 16ab7cb ("crypto: pkcs7 - remove sha1 support") previously removed support for reading PKCS#7/CMS signed with SHA-1, along with the ability to use SHA-1 for module signing. This change broke iwd and was subsequently completely reverted in commit 203a676 ("Revert "crypto: pkcs7 - remove sha1 support""). However, dropping only the support for using SHA-1 for module signing is unrelated and can still be done separately. Note that this change only removes support for new modules to be SHA-1 signed, but already signed modules can still be loaded. Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Reviewed-by: Aaron Tomlin <atomlin@atomlin.com> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
1 parent 581ac2d commit 148519a

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

kernel/module/Kconfig

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -299,10 +299,6 @@ choice
299299
possible to load a signed module containing the algorithm to check
300300
the signature on that module.
301301

302-
config MODULE_SIG_SHA1
303-
bool "SHA-1"
304-
select CRYPTO_SHA1
305-
306302
config MODULE_SIG_SHA256
307303
bool "SHA-256"
308304
select CRYPTO_SHA256
@@ -332,7 +328,6 @@ endchoice
332328
config MODULE_SIG_HASH
333329
string
334330
depends on MODULE_SIG || IMA_APPRAISE_MODSIG
335-
default "sha1" if MODULE_SIG_SHA1
336331
default "sha256" if MODULE_SIG_SHA256
337332
default "sha384" if MODULE_SIG_SHA384
338333
default "sha512" if MODULE_SIG_SHA512

0 commit comments

Comments
 (0)