Skip to content

Commit 148891e

Browse files
2045geminiChristophe Leroy (CS GROUP)
authored andcommitted
bus: fsl-mc: fix use-after-free in driver_override_show()
The driver_override_show() function reads the driver_override string without holding the device_lock. However, driver_override_store() uses driver_set_override(), which modifies and frees the string while holding the device_lock. This can result in a concurrent use-after-free if the string is freed by the store function while being read by the show function. Fix this by holding the device_lock around the read operation. Fixes: 1f86a00 ("bus/fsl-mc: add support for 'driver_override' in the mc-bus") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han <hanguidong02@gmail.com> Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com> Link: https://lore.kernel.org/r/20251202174438.12658-1-hanguidong02@gmail.com Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
1 parent c8dff80 commit 148891e

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

drivers/bus/fsl-mc/fsl-mc-bus.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,12 @@ static ssize_t driver_override_show(struct device *dev,
231231
struct device_attribute *attr, char *buf)
232232
{
233233
struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
234+
ssize_t len;
234235

235-
return sysfs_emit(buf, "%s\n", mc_dev->driver_override);
236+
device_lock(dev);
237+
len = sysfs_emit(buf, "%s\n", mc_dev->driver_override);
238+
device_unlock(dev);
239+
return len;
236240
}
237241
static DEVICE_ATTR_RW(driver_override);
238242

0 commit comments

Comments
 (0)