Skip to content

Commit 148ddaa

Browse files
diandersbebarino
authored andcommitted
clk: qcom: gcc-sc7180: Use floor ops for the correct sdcc1 clk
While picking commit a8cd989 ("mmc: sdhci-msm: Warn about overclocking SD/MMC") back to my tree I was surprised that it was reporting warnings. I thought I fixed those! Looking closer at the fix, I see that I totally bungled it (or at least I halfway bungled it). The SD card clock got fixed (and that was the one I was really focused on fixing), but I totally adjusted the wrong clock for eMMC. Sigh. Let's fix my dumb mistake. Now both SD and eMMC have floor for the "apps" clock. This doesn't matter a lot for the final clock rate for HS400 eMMC but could matter if someone happens to put some slower eMMC on a sc7180. We also transition through some of these lower rates sometimes and having them wrong could cause problems during these transitions. These were the messages I was seeing at boot: mmc1: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz mmc1: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz mmc1: Card appears overclocked; req 104000000 Hz, actual 192000000 Hz Fixes: 6d37a8d ("clk: qcom: gcc-sc7180: Use floor ops for sdcc clks") Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20210224095013.1.I2e2ba4978cfca06520dfb5d757768f9c42140f7c@changeid Reviewed-by: Taniya Das <tdas@codeaurora.org> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 0ae6712 commit 148ddaa

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/clk/qcom/gcc-sc7180.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
620620
.name = "gcc_sdcc1_apps_clk_src",
621621
.parent_data = gcc_parent_data_1,
622622
.num_parents = 5,
623-
.ops = &clk_rcg2_ops,
623+
.ops = &clk_rcg2_floor_ops,
624624
},
625625
};
626626

@@ -642,7 +642,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
642642
.name = "gcc_sdcc1_ice_core_clk_src",
643643
.parent_data = gcc_parent_data_0,
644644
.num_parents = 4,
645-
.ops = &clk_rcg2_floor_ops,
645+
.ops = &clk_rcg2_ops,
646646
},
647647
};
648648

0 commit comments

Comments
 (0)