Skip to content

Commit 14ca8ce

Browse files
David Laightherbertx
authored andcommitted
crypto: ccp - use min() instead of min_t()
min_t(unsigned int, a, b) casts an 'unsigned long' to 'unsigned int'. Use min(a, b) instead as it promotes any 'unsigned int' to 'unsigned long' and so cannot discard significant bits. In this case the 'unsigned long' value is small enough that the result is ok. Detected by an extra check added to min_t(). Signed-off-by: David Laight <david.laight.linux@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 0f8ead5 commit 14ca8ce

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/crypto/ccp/ccp-dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ int ccp_trng_read(struct hwrng *rng, void *data, size_t max, bool wait)
507507
{
508508
struct ccp_device *ccp = container_of(rng, struct ccp_device, hwrng);
509509
u32 trng_value;
510-
int len = min_t(int, sizeof(trng_value), max);
510+
int len = min(sizeof(trng_value), max);
511511

512512
/* Locking is provided by the caller so we can update device
513513
* hwrng-related fields safely

0 commit comments

Comments
 (0)