Skip to content

Commit 151d092

Browse files
Christoph Hellwigbrauner
authored andcommitted
writeback: cleanup writeback_chunk_size
Return the pages directly when calculated instead of first assigning them back to a variable, and directly return for the data integrity / tagged case instead of going through an else clause. Signed-off-by: Christoph Hellwig <hch@lst.de> Link: https://patch.msgid.link/20251017034611.651385-2-hch@lst.de Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 211c43d commit 151d092

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

fs/fs-writeback.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1908,16 +1908,12 @@ static long writeback_chunk_size(struct bdi_writeback *wb,
19081908
* (maybe slowly) sync all tagged pages
19091909
*/
19101910
if (work->sync_mode == WB_SYNC_ALL || work->tagged_writepages)
1911-
pages = LONG_MAX;
1912-
else {
1913-
pages = min(wb->avg_write_bandwidth / 2,
1914-
global_wb_domain.dirty_limit / DIRTY_SCOPE);
1915-
pages = min(pages, work->nr_pages);
1916-
pages = round_down(pages + MIN_WRITEBACK_PAGES,
1917-
MIN_WRITEBACK_PAGES);
1918-
}
1911+
return LONG_MAX;
19191912

1920-
return pages;
1913+
pages = min(wb->avg_write_bandwidth / 2,
1914+
global_wb_domain.dirty_limit / DIRTY_SCOPE);
1915+
pages = min(pages, work->nr_pages);
1916+
return round_down(pages + MIN_WRITEBACK_PAGES, MIN_WRITEBACK_PAGES);
19211917
}
19221918

19231919
/*

0 commit comments

Comments
 (0)