mm/damon/sysfs: remove repeat container_of() in damon_sysfs_kdamond_release()

Xin Hao · torvalds · commit 15423a52cc84 · 2022-03-22T15:57:13.000-07:00
In damon_sysfs_kdamond_release(), we have use container_of() to get "kdamond" pointer, so there no need to get it once again. Link: https://lkml.kernel.org/r/20220303075314.22502-1-xhao@linux.alibaba.com Signed-off-by: Xin Hao <xhao@linux.alibaba.com> Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
@@ -2345,7 +2345,7 @@ static void damon_sysfs_kdamond_release(struct kobject *kobj)
 
 	if (kdamond->damon_ctx)
 		damon_destroy_ctx(kdamond->damon_ctx);
-	kfree(container_of(kobj, struct damon_sysfs_kdamond, kobj));
+	kfree(kdamond);
 }
 
 static struct kobj_attribute damon_sysfs_kdamond_state_attr =

Original file line number	Diff line number	Diff line change
`@@ -2345,7 +2345,7 @@ static void damon_sysfs_kdamond_release(struct kobject *kobj)`
`2345`	`2345`
`2346`	`2346`	`if (kdamond->damon_ctx)`
`2347`	`2347`	`damon_destroy_ctx(kdamond->damon_ctx);`
`2348`		`- kfree(container_of(kobj, struct damon_sysfs_kdamond, kobj));`
	`2348`	`+ kfree(kdamond);`
`2349`	`2349`	`}`
`2350`	`2350`
`2351`	`2351`	`static struct kobj_attribute damon_sysfs_kdamond_state_attr =`