Skip to content

Commit 1562a53

Browse files
committed
drm/i915: Extract intel_connector_cancel_modeset_retry_work()
Hide the implementation details of the modeset retry work better. v2: Include prototype and sort includes correctly (Jani) Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250213150220.13580-4-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent 78ecd90 commit 1562a53

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/intel_connector.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,12 @@ void intel_connector_queue_modeset_retry_work(struct intel_connector *connector)
7070
drm_connector_put(&connector->base);
7171
}
7272

73+
void intel_connector_cancel_modeset_retry_work(struct intel_connector *connector)
74+
{
75+
if (cancel_work_sync(&connector->modeset_retry_work))
76+
drm_connector_put(&connector->base);
77+
}
78+
7379
int intel_connector_init(struct intel_connector *connector)
7480
{
7581
struct intel_digital_connector_state *conn_state;

drivers/gpu/drm/i915/display/intel_connector.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,6 @@ void intel_attach_hdmi_colorspace_property(struct drm_connector *connector);
3434
void intel_attach_dp_colorspace_property(struct drm_connector *connector);
3535
void intel_attach_scaling_mode_property(struct drm_connector *connector);
3636
void intel_connector_queue_modeset_retry_work(struct intel_connector *connector);
37+
void intel_connector_cancel_modeset_retry_work(struct intel_connector *connector);
3738

3839
#endif /* __INTEL_CONNECTOR_H__ */

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
#include "intel_cdclk.h"
6464
#include "intel_clock_gating.h"
6565
#include "intel_color.h"
66+
#include "intel_connector.h"
6667
#include "intel_crt.h"
6768
#include "intel_crtc.h"
6869
#include "intel_crtc_state_dump.h"
@@ -8544,8 +8545,7 @@ void intel_hpd_poll_fini(struct drm_i915_private *i915)
85448545
/* Kill all the work that may have been queued by hpd. */
85458546
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
85468547
for_each_intel_connector_iter(connector, &conn_iter) {
8547-
if (cancel_work_sync(&connector->modeset_retry_work))
8548-
drm_connector_put(&connector->base);
8548+
intel_connector_cancel_modeset_retry_work(connector);
85498549
if (connector->hdcp.shim) {
85508550
cancel_delayed_work_sync(&connector->hdcp.check_work);
85518551
cancel_work_sync(&connector->hdcp.prop_work);

0 commit comments

Comments
 (0)