Skip to content

Commit 160d686

Browse files
krzklinusw
authored andcommitted
pinctrl: tegra-xusb: Simplify locking with guard()
Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Linus Walleij <linusw@kernel.org>
1 parent 0899bab commit 160d686

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

drivers/pinctrl/tegra/pinctrl-tegra-xusb.c

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -478,10 +478,10 @@ static void tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl)
478478
{
479479
u32 value;
480480

481-
mutex_lock(&padctl->lock);
481+
guard(mutex)(&padctl->lock);
482482

483483
if (padctl->enable++ > 0)
484-
goto out;
484+
return;
485485

486486
value = padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM);
487487
value &= ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN;
@@ -498,22 +498,19 @@ static void tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl)
498498
value = padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM);
499499
value &= ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN;
500500
padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM);
501-
502-
out:
503-
mutex_unlock(&padctl->lock);
504501
}
505502

506503
static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl)
507504
{
508505
u32 value;
509506

510-
mutex_lock(&padctl->lock);
507+
guard(mutex)(&padctl->lock);
511508

512509
if (WARN_ON(padctl->enable == 0))
513-
goto out;
510+
return;
514511

515512
if (--padctl->enable > 0)
516-
goto out;
513+
return;
517514

518515
value = padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM);
519516
value |= XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN;
@@ -530,9 +527,6 @@ static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl)
530527
value = padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM);
531528
value |= XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN;
532529
padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM);
533-
534-
out:
535-
mutex_unlock(&padctl->lock);
536530
}
537531

538532
static int tegra_xusb_phy_init(struct phy *phy)

0 commit comments

Comments
 (0)