Skip to content

Commit 1620c80

Browse files
c0d3z3r0jwrdegoede
authored andcommitted
platform/x86: intel-hid: fix _DSM function index handling
intel_hid_dsm_fn_mask is a bit mask containing one bit for each function index. Fix the function index check in intel_hid_evaluate_method accordingly, which was missed in commit 97ab451 ("platform/x86: intel-hid: fix _DSM function index handling"). Fixes: 97ab451 ("platform/x86: intel-hid: fix _DSM function index handling") Cc: stable@vger.kernel.org Signed-off-by: Michael Niewöhner <linux@mniewoehner.de> Link: https://lore.kernel.org/r/66f813f5bcc724a0f6dd5adefe6a9728dbe509e3.camel@mniewoehner.de Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 46ecf72 commit 1620c80

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/platform/x86/intel

drivers/platform/x86/intel/hid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
238238

239239
method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
240240

241-
if (!(intel_hid_dsm_fn_mask & fn_index))
241+
if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
242242
goto skip_dsm_eval;
243243

244244
obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,

0 commit comments

Comments
 (0)