Skip to content

Commit 16c230b

Browse files
committed
arm64: scs: Drop unused 'tmp' argument to scs_{load, save} asm macros
The scs_load and scs_save asm macros don't make use of the mandatory 'tmp' register argument, so drop it and fix up the callers. Cc: Sami Tolvanen <samitolvanen@google.com> Cc: Mark Rutland <mark.rutland@arm.com> Acked-by: Mark Rutland <mark.rutland@arm.com> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://lore.kernel.org/r/20210527105529.21967-1-will@kernel.org Signed-off-by: Will Deacon <will@kernel.org>
1 parent 3d8c1a0 commit 16c230b

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

arch/arm64/include/asm/scs.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@
99
#ifdef CONFIG_SHADOW_CALL_STACK
1010
scs_sp .req x18
1111

12-
.macro scs_load tsk, tmp
12+
.macro scs_load tsk
1313
ldr scs_sp, [\tsk, #TSK_TI_SCS_SP]
1414
.endm
1515

16-
.macro scs_save tsk, tmp
16+
.macro scs_save tsk
1717
str scs_sp, [\tsk, #TSK_TI_SCS_SP]
1818
.endm
1919
#else
20-
.macro scs_load tsk, tmp
20+
.macro scs_load tsk
2121
.endm
2222

23-
.macro scs_save tsk, tmp
23+
.macro scs_save tsk
2424
.endm
2525
#endif /* CONFIG_SHADOW_CALL_STACK */
2626

arch/arm64/kernel/entry.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ alternative_else_nop_endif
275275

276276
mte_set_kernel_gcr x22, x23
277277

278-
scs_load tsk, x20
278+
scs_load tsk
279279
.else
280280
add x21, sp, #PT_REGS_SIZE
281281
get_current_task tsk
@@ -375,7 +375,7 @@ alternative_if ARM64_WORKAROUND_845719
375375
alternative_else_nop_endif
376376
#endif
377377
3:
378-
scs_save tsk, x0
378+
scs_save tsk
379379

380380
#ifdef CONFIG_ARM64_PTR_AUTH
381381
alternative_if ARM64_HAS_ADDRESS_AUTH
@@ -979,8 +979,8 @@ SYM_FUNC_START(cpu_switch_to)
979979
mov sp, x9
980980
msr sp_el0, x1
981981
ptrauth_keys_install_kernel x1, x8, x9, x10
982-
scs_save x0, x8
983-
scs_load x1, x8
982+
scs_save x0
983+
scs_load x1
984984
ret
985985
SYM_FUNC_END(cpu_switch_to)
986986
NOKPROBE(cpu_switch_to)

arch/arm64/kernel/head.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ SYM_FUNC_END(__create_page_tables)
412412
stp xzr, xzr, [sp, #S_STACKFRAME]
413413
add x29, sp, #S_STACKFRAME
414414

415-
scs_load \tsk, \tmp1
415+
scs_load \tsk
416416

417417
adr_l \tmp1, __per_cpu_offset
418418
ldr w\tmp2, [\tsk, #TSK_CPU]

0 commit comments

Comments
 (0)