dlm: remove unnecessary INIT_LIST_HEAD()

Alexander Aring · teigland · commit 16d58904dfeb · 2022-04-06T14:02:13.000-05:00
There is no need to call INIT_LIST_HEAD() when it's set directly
afterwards by list_add_tail().

Reported-by: Andreas Gruenbacher &lt;agruenba@redhat.com&gt;
Signed-off-by: Alexander Aring &lt;aahringo@redhat.com&gt;
Signed-off-by: David Teigland &lt;teigland@redhat.com&gt;
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
@@ -67,7 +67,6 @@ static void dlm_release_plock_op(struct plock_op *op)
 static void send_op(struct plock_op *op)
 {
 	set_version(&op->info);
-	INIT_LIST_HEAD(&op->list);
 	spin_lock(&ops_lock);
 	list_add_tail(&op->list, &send_list);
 	spin_unlock(&ops_lock);

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ static void dlm_release_plock_op(struct plock_op *op)`
`67`	`67`	`static void send_op(struct plock_op *op)`
`68`	`68`	`{`
`69`	`69`	`set_version(&op->info);`
`70`		`- INIT_LIST_HEAD(&op->list);`
`71`	`70`	`spin_lock(&ops_lock);`
`72`	`71`	`list_add_tail(&op->list, &send_list);`
`73`	`72`	`spin_unlock(&ops_lock);`