Skip to content

Commit 17224e0

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Remove for_each_m4u in tlb_sync_all
The tlb_sync_all is called from these three functions: a) flush_iotlb_all: it will be called for each a iommu HW. b) tlb_flush_range_sync: it already has for_each_m4u. c) in irq: When IOMMU HW translation fault, Only need flush itself. Thus, No need for_each_m4u in this tlb_sync_all. Remove it. Signed-off-by: Yong Wu <yong.wu@mediatek.com> Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20211208120744.2415-2-dafna.hirschfeld@collabora.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 754e0b0 commit 17224e0

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

drivers/iommu/mtk_iommu.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -210,17 +210,15 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)
210210

211211
static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
212212
{
213-
for_each_m4u(data) {
214-
if (pm_runtime_get_if_in_use(data->dev) <= 0)
215-
continue;
213+
if (pm_runtime_get_if_in_use(data->dev) <= 0)
214+
return;
216215

217-
writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
218-
data->base + data->plat_data->inv_sel_reg);
219-
writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
220-
wmb(); /* Make sure the tlb flush all done */
216+
writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
217+
data->base + data->plat_data->inv_sel_reg);
218+
writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
219+
wmb(); /* Make sure the tlb flush all done */
221220

222-
pm_runtime_put(data->dev);
223-
}
221+
pm_runtime_put(data->dev);
224222
}
225223

226224
static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,

0 commit comments

Comments
 (0)