Skip to content

Commit 17673f6

Browse files
committed
cpuidle: governors: teo: Drop redundant function parameter
The last no_poll parameter of teo_find_shallower_state() is always false, so drop it. No intentional functional impact. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Christian Loehle <christian.loehle@arm.com> Tested-by: Christian Loehle <christian.loehle@arm.com> Link: https://patch.msgid.link/2253109.irdbgypaU6@rafael.j.wysocki
1 parent a03b201 commit 17673f6

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

  • drivers/cpuidle/governors

drivers/cpuidle/governors/teo.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,17 +239,15 @@ static bool teo_state_ok(int i, struct cpuidle_driver *drv)
239239
* @dev: Target CPU.
240240
* @state_idx: Index of the capping idle state.
241241
* @duration_ns: Idle duration value to match.
242-
* @no_poll: Don't consider polling states.
243242
*/
244243
static int teo_find_shallower_state(struct cpuidle_driver *drv,
245244
struct cpuidle_device *dev, int state_idx,
246-
s64 duration_ns, bool no_poll)
245+
s64 duration_ns)
247246
{
248247
int i;
249248

250249
for (i = state_idx - 1; i >= 0; i--) {
251-
if (dev->states_usage[i].disable ||
252-
(no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING))
250+
if (dev->states_usage[i].disable)
253251
continue;
254252

255253
state_idx = i;
@@ -459,7 +457,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
459457
* candidate state, a shallower one needs to be found.
460458
*/
461459
if (drv->states[idx].target_residency_ns > duration_ns)
462-
idx = teo_find_shallower_state(drv, dev, idx, duration_ns, false);
460+
idx = teo_find_shallower_state(drv, dev, idx, duration_ns);
463461

464462
/*
465463
* If the selected state's target residency is below the tick length
@@ -487,7 +485,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
487485
*/
488486
if (idx > idx0 &&
489487
drv->states[idx].target_residency_ns > delta_tick)
490-
idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false);
488+
idx = teo_find_shallower_state(drv, dev, idx, delta_tick);
491489

492490
out_tick:
493491
*stop_tick = false;

0 commit comments

Comments
 (0)