Skip to content

Commit 1769f90

Browse files
Carlos Llamasgregkh
authored andcommitted
binder: fix BR_FROZEN_REPLY error log
The error logging for failed transactions is misleading as it always reports "dead process or thread" even when the target is actually frozen. Additionally, the pid and tid are reversed which can further confuse debugging efforts. Fix both issues. Cc: stable@kernel.org Cc: Steven Moreland <smoreland@google.com> Fixes: a15dac8 ("binder: additional transaction error logs") Signed-off-by: Carlos Llamas <cmllamas@google.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Link: https://patch.msgid.link/20260123175702.2154348-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d047248 commit 1769f90

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/android/binder.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3824,8 +3824,9 @@ static void binder_transaction(struct binder_proc *proc,
38243824
return;
38253825

38263826
err_dead_proc_or_thread:
3827-
binder_txn_error("%d:%d dead process or thread\n",
3828-
thread->pid, proc->pid);
3827+
binder_txn_error("%d:%d %s process or thread\n",
3828+
proc->pid, thread->pid,
3829+
return_error == BR_FROZEN_REPLY ? "frozen" : "dead");
38293830
return_error_line = __LINE__;
38303831
binder_dequeue_work(proc, tcomplete);
38313832
err_translate_failed:

0 commit comments

Comments
 (0)