Skip to content

Commit 17ea371

Browse files
zhouzhouyi-hubpaulmckrcu
authored andcommitted
rcu: Improve tree_plugin.h comments and add code cleanups
This commit cleans up some comments and code in kernel/rcu/tree_plugin.h. Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent 2407a64 commit 17ea371

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

kernel/rcu/tree_plugin.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
static bool rcu_rdp_is_offloaded(struct rcu_data *rdp)
1717
{
1818
/*
19-
* In order to read the offloaded state of an rdp is a safe
19+
* In order to read the offloaded state of an rdp in a safe
2020
* and stable way and prevent from its value to be changed
2121
* under us, we must either hold the barrier mutex, the cpu
2222
* hotplug lock (read or write) or the nocb lock. Local
@@ -56,7 +56,7 @@ static void __init rcu_bootup_announce_oddness(void)
5656
if (IS_ENABLED(CONFIG_PROVE_RCU))
5757
pr_info("\tRCU lockdep checking is enabled.\n");
5858
if (IS_ENABLED(CONFIG_RCU_STRICT_GRACE_PERIOD))
59-
pr_info("\tRCU strict (and thus non-scalable) grace periods enabled.\n");
59+
pr_info("\tRCU strict (and thus non-scalable) grace periods are enabled.\n");
6060
if (RCU_NUM_LVLS >= 4)
6161
pr_info("\tFour(or more)-level hierarchy is enabled.\n");
6262
if (RCU_FANOUT_LEAF != 16)
@@ -88,13 +88,13 @@ static void __init rcu_bootup_announce_oddness(void)
8888
if (rcu_kick_kthreads)
8989
pr_info("\tKick kthreads if too-long grace period.\n");
9090
if (IS_ENABLED(CONFIG_DEBUG_OBJECTS_RCU_HEAD))
91-
pr_info("\tRCU callback double-/use-after-free debug enabled.\n");
91+
pr_info("\tRCU callback double-/use-after-free debug is enabled.\n");
9292
if (gp_preinit_delay)
9393
pr_info("\tRCU debug GP pre-init slowdown %d jiffies.\n", gp_preinit_delay);
9494
if (gp_init_delay)
9595
pr_info("\tRCU debug GP init slowdown %d jiffies.\n", gp_init_delay);
9696
if (gp_cleanup_delay)
97-
pr_info("\tRCU debug GP init slowdown %d jiffies.\n", gp_cleanup_delay);
97+
pr_info("\tRCU debug GP cleanup slowdown %d jiffies.\n", gp_cleanup_delay);
9898
if (!use_softirq)
9999
pr_info("\tRCU_SOFTIRQ processing moved to rcuc kthreads.\n");
100100
if (IS_ENABLED(CONFIG_RCU_EQS_DEBUG))
@@ -1153,7 +1153,6 @@ static void rcu_preempt_boost_start_gp(struct rcu_node *rnp)
11531153
/*
11541154
* Create an RCU-boost kthread for the specified node if one does not
11551155
* already exist. We only create this kthread for preemptible RCU.
1156-
* Returns zero if all is well, a negated errno otherwise.
11571156
*/
11581157
static void rcu_spawn_one_boost_kthread(struct rcu_node *rnp)
11591158
{
@@ -1455,7 +1454,7 @@ static void rcu_cleanup_after_idle(void)
14551454
* CPU unless the grace period has extended for too long.
14561455
*
14571456
* This code relies on the fact that all NO_HZ_FULL CPUs are also
1458-
* CONFIG_RCU_NOCB_CPU CPUs.
1457+
* RCU_NOCB_CPU CPUs.
14591458
*/
14601459
static bool rcu_nohz_full_cpu(void)
14611460
{

0 commit comments

Comments
 (0)