Skip to content

Commit 182422c

Browse files
LiHuiSong1rafaeljw
authored andcommitted
ACPI: processor: idle: Convert acpi_processor_setup_cpuidle_states() to void
Since all callers of acpi_processor_setup_cpuidle_states() ignore its return value and it simply passes the acpi_processor_setup_lpi_states() return value to its callers, convert both of these functions to void. No intentional functional impact. Signed-off-by: Huisong Li <lihuisong@huawei.com> [ rjw: Subject and changelog edits ] Link: https://patch.msgid.link/20260120112258.1595164-2-lihuisong@huawei.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 9be3520 commit 182422c

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

drivers/acpi/processor_idle.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,15 +1180,15 @@ static int acpi_idle_lpi_enter(struct cpuidle_device *dev,
11801180
return -EINVAL;
11811181
}
11821182

1183-
static int acpi_processor_setup_lpi_states(struct acpi_processor *pr)
1183+
static void acpi_processor_setup_lpi_states(struct acpi_processor *pr)
11841184
{
11851185
int i;
11861186
struct acpi_lpi_state *lpi;
11871187
struct cpuidle_state *state;
11881188
struct cpuidle_driver *drv = &acpi_idle_driver;
11891189

11901190
if (!pr->flags.has_lpi)
1191-
return -EOPNOTSUPP;
1191+
return;
11921192

11931193
for (i = 0; i < pr->power.count && i < CPUIDLE_STATE_MAX; i++) {
11941194
lpi = &pr->power.lpi_states[i];
@@ -1206,8 +1206,6 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr)
12061206
}
12071207

12081208
drv->state_count = i;
1209-
1210-
return 0;
12111209
}
12121210

12131211
/**
@@ -1216,25 +1214,26 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr)
12161214
*
12171215
* @pr: the ACPI processor
12181216
*/
1219-
static int acpi_processor_setup_cpuidle_states(struct acpi_processor *pr)
1217+
static void acpi_processor_setup_cpuidle_states(struct acpi_processor *pr)
12201218
{
12211219
int i;
12221220
struct cpuidle_driver *drv = &acpi_idle_driver;
12231221

12241222
if (!pr->flags.power_setup_done || !pr->flags.power)
1225-
return -EINVAL;
1223+
return;
12261224

12271225
drv->safe_state_index = -1;
12281226
for (i = ACPI_IDLE_STATE_START; i < CPUIDLE_STATE_MAX; i++) {
12291227
drv->states[i].name[0] = '\0';
12301228
drv->states[i].desc[0] = '\0';
12311229
}
12321230

1233-
if (pr->flags.has_lpi)
1234-
return acpi_processor_setup_lpi_states(pr);
1231+
if (pr->flags.has_lpi) {
1232+
acpi_processor_setup_lpi_states(pr);
1233+
return;
1234+
}
12351235

12361236
acpi_processor_setup_cstates(pr);
1237-
return 0;
12381237
}
12391238

12401239
/**

0 commit comments

Comments
 (0)