Skip to content

Commit 1838ffe

Browse files
paulmenzelrafaeljw
authored andcommitted
ACPICA: executer/exsystem: Add units to time variable names
ACPICA commit b69cbef7a83eadb102a1ff6c6f6fc5abce34805a `how_long` refers to different units in both functions, so make it more clear, what unit they expect. That also makes one comment superfluous. Link: acpica/acpica@b69cbef7 Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent aa29b20 commit 1838ffe

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

drivers/acpi/acpica/exsystem.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout)
107107
*
108108
* FUNCTION: acpi_ex_system_do_stall
109109
*
110-
* PARAMETERS: how_long - The amount of time to stall,
110+
* PARAMETERS: how_long_us - The amount of time to stall,
111111
* in microseconds
112112
*
113113
* RETURN: Status
@@ -120,24 +120,24 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout)
120120
*
121121
******************************************************************************/
122122

123-
acpi_status acpi_ex_system_do_stall(u32 how_long)
123+
acpi_status acpi_ex_system_do_stall(u32 how_long_us)
124124
{
125125
acpi_status status = AE_OK;
126126

127127
ACPI_FUNCTION_ENTRY();
128128

129-
if (how_long > 255) { /* 255 microseconds */
129+
if (how_long_us > 255) {
130130
/*
131-
* Longer than 255 usec, this is an error
131+
* Longer than 255 microseconds, this is an error
132132
*
133133
* (ACPI specifies 100 usec as max, but this gives some slack in
134134
* order to support existing BIOSs)
135135
*/
136136
ACPI_ERROR((AE_INFO,
137-
"Time parameter is too large (%u)", how_long));
137+
"Time parameter is too large (%u)", how_long_us));
138138
status = AE_AML_OPERAND_VALUE;
139139
} else {
140-
acpi_os_stall(how_long);
140+
acpi_os_stall(how_long_us);
141141
}
142142

143143
return (status);
@@ -147,7 +147,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long)
147147
*
148148
* FUNCTION: acpi_ex_system_do_sleep
149149
*
150-
* PARAMETERS: how_long - The amount of time to sleep,
150+
* PARAMETERS: how_long_ms - The amount of time to sleep,
151151
* in milliseconds
152152
*
153153
* RETURN: None
@@ -156,7 +156,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long)
156156
*
157157
******************************************************************************/
158158

159-
acpi_status acpi_ex_system_do_sleep(u64 how_long)
159+
acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
160160
{
161161
ACPI_FUNCTION_ENTRY();
162162

@@ -168,11 +168,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long)
168168
* For compatibility with other ACPI implementations and to prevent
169169
* accidental deep sleeps, limit the sleep time to something reasonable.
170170
*/
171-
if (how_long > ACPI_MAX_SLEEP) {
172-
how_long = ACPI_MAX_SLEEP;
171+
if (how_long_ms > ACPI_MAX_SLEEP) {
172+
how_long_ms = ACPI_MAX_SLEEP;
173173
}
174174

175-
acpi_os_sleep(how_long);
175+
acpi_os_sleep(how_long_ms);
176176

177177
/* And now we must get the interpreter again */
178178

0 commit comments

Comments
 (0)