Skip to content

Commit 184416d

Browse files
Dan Carpenterchucklever
authored andcommitted
NFSD: prevent underflow in nfssvc_decode_writeargs()
Smatch complains: fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs() warn: no lower bound on 'args->len' Change the type to unsigned to prevent this issue. Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 9d66477 commit 184416d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

fs/nfsd/nfsproc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
230230
unsigned long cnt = argp->len;
231231
unsigned int nvecs;
232232

233-
dprintk("nfsd: WRITE %s %d bytes at %d\n",
233+
dprintk("nfsd: WRITE %s %u bytes at %d\n",
234234
SVCFH_fmt(&argp->fh),
235235
argp->len, argp->offset);
236236

fs/nfsd/xdr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ struct nfsd_readargs {
3232
struct nfsd_writeargs {
3333
svc_fh fh;
3434
__u32 offset;
35-
int len;
35+
__u32 len;
3636
struct xdr_buf payload;
3737
};
3838

0 commit comments

Comments
 (0)