Skip to content

Commit 1879c2e

Browse files
DispatchCodegregkh
authored andcommitted
tty: replace use of system_unbound_wq with system_dfl_wq
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") system_dfl_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Link: https://patch.msgid.link/20251104105446.110884-1-marco.crivellari@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent da21840 commit 1879c2e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/tty/serial/8250/8250_dw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ static int dw8250_clk_notifier_cb(struct notifier_block *nb,
361361
* deferred event handling complication.
362362
*/
363363
if (event == POST_RATE_CHANGE) {
364-
queue_work(system_unbound_wq, &d->clk_work);
364+
queue_work(system_dfl_wq, &d->clk_work);
365365
return NOTIFY_OK;
366366
}
367367

@@ -680,7 +680,7 @@ static int dw8250_probe(struct platform_device *pdev)
680680
err = clk_notifier_register(data->clk, &data->clk_notifier);
681681
if (err)
682682
return dev_err_probe(dev, err, "Failed to set the clock notifier\n");
683-
queue_work(system_unbound_wq, &data->clk_work);
683+
queue_work(system_dfl_wq, &data->clk_work);
684684
}
685685

686686
platform_set_drvdata(pdev, data);

drivers/tty/tty_buffer.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ void tty_buffer_unlock_exclusive(struct tty_port *port)
7676
mutex_unlock(&buf->lock);
7777

7878
if (restart)
79-
queue_work(system_unbound_wq, &buf->work);
79+
queue_work(system_dfl_wq, &buf->work);
8080
}
8181
EXPORT_SYMBOL_GPL(tty_buffer_unlock_exclusive);
8282

@@ -530,7 +530,7 @@ void tty_flip_buffer_push(struct tty_port *port)
530530
struct tty_bufhead *buf = &port->buf;
531531

532532
tty_flip_buffer_commit(buf->tail);
533-
queue_work(system_unbound_wq, &buf->work);
533+
queue_work(system_dfl_wq, &buf->work);
534534
}
535535
EXPORT_SYMBOL(tty_flip_buffer_push);
536536

@@ -560,7 +560,7 @@ int tty_insert_flip_string_and_push_buffer(struct tty_port *port,
560560
tty_flip_buffer_commit(buf->tail);
561561
spin_unlock_irqrestore(&port->lock, flags);
562562

563-
queue_work(system_unbound_wq, &buf->work);
563+
queue_work(system_dfl_wq, &buf->work);
564564

565565
return size;
566566
}
@@ -613,7 +613,7 @@ void tty_buffer_set_lock_subclass(struct tty_port *port)
613613

614614
bool tty_buffer_restart_work(struct tty_port *port)
615615
{
616-
return queue_work(system_unbound_wq, &port->buf.work);
616+
return queue_work(system_dfl_wq, &port->buf.work);
617617
}
618618

619619
bool tty_buffer_cancel_work(struct tty_port *port)

0 commit comments

Comments
 (0)