Skip to content

Commit 18b3ff9

Browse files
committed
netfs: Adjust the netfs_rreq tracepoint slightly
Adjust the netfs_rreq tracepoint to include the origin of the request and to increase the size of the "what trace" output strings by a character so that "ENCRYPT" and "DECRYPT" will fit without abbreviation. Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> cc: linux-cachefs@redhat.com Link: https://lore.kernel.org/r/164622996715.3564931.4252319907990358129.stgit@warthog.procyon.org.uk/ # v1 Link: https://lore.kernel.org/r/164678199468.1200972.17275585970238114726.stgit@warthog.procyon.org.uk/ # v2 Link: https://lore.kernel.org/r/164692898684.2099075.12153225958137716567.stgit@warthog.procyon.org.uk/ # v3
1 parent 3a4a38e commit 18b3ff9

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

fs/netfs/read_helper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ static void netfs_rreq_do_write_to_cache(struct netfs_io_request *rreq)
181181
struct iov_iter iter;
182182
int ret;
183183

184-
trace_netfs_rreq(rreq, netfs_rreq_trace_write);
184+
trace_netfs_rreq(rreq, netfs_rreq_trace_copy);
185185

186186
/* We don't want terminating writes trying to wake us up whilst we're
187187
* still going through the list.

include/trace/events/netfs.h

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
E_(netfs_read_trace_write_begin, "WRITEBEGN")
2323

2424
#define netfs_rreq_traces \
25-
EM(netfs_rreq_trace_assess, "ASSESS") \
26-
EM(netfs_rreq_trace_done, "DONE ") \
27-
EM(netfs_rreq_trace_free, "FREE ") \
28-
EM(netfs_rreq_trace_resubmit, "RESUBM") \
29-
EM(netfs_rreq_trace_unlock, "UNLOCK") \
30-
EM(netfs_rreq_trace_unmark, "UNMARK") \
31-
E_(netfs_rreq_trace_write, "WRITE ")
25+
EM(netfs_rreq_trace_assess, "ASSESS ") \
26+
EM(netfs_rreq_trace_copy, "COPY ") \
27+
EM(netfs_rreq_trace_done, "DONE ") \
28+
EM(netfs_rreq_trace_free, "FREE ") \
29+
EM(netfs_rreq_trace_resubmit, "RESUBMT") \
30+
EM(netfs_rreq_trace_unlock, "UNLOCK ") \
31+
E_(netfs_rreq_trace_unmark, "UNMARK ")
3232

3333
#define netfs_sreq_sources \
3434
EM(NETFS_FILL_WITH_ZEROES, "ZERO") \
@@ -134,7 +134,7 @@ TRACE_EVENT(netfs_rreq,
134134

135135
TP_STRUCT__entry(
136136
__field(unsigned int, rreq )
137-
__field(unsigned short, flags )
137+
__field(unsigned int, flags )
138138
__field(enum netfs_rreq_trace, what )
139139
),
140140

@@ -182,8 +182,8 @@ TRACE_EVENT(netfs_sreq,
182182

183183
TP_printk("R=%08x[%u] %s %s f=%02x s=%llx %zx/%zx e=%d",
184184
__entry->rreq, __entry->index,
185-
__print_symbolic(__entry->what, netfs_sreq_traces),
186185
__print_symbolic(__entry->source, netfs_sreq_sources),
186+
__print_symbolic(__entry->what, netfs_sreq_traces),
187187
__entry->flags,
188188
__entry->start, __entry->transferred, __entry->len,
189189
__entry->error)

0 commit comments

Comments
 (0)