Skip to content

Commit 18c16f6

Browse files
Nirjhar-Roy-0211cmaiolino
authored andcommitted
xfs: Replace ASSERT with XFS_IS_CORRUPT in xfs_rtcopy_summary()
Replace ASSERT(sum > 0) with an XFS_IS_CORRUPT() and place it just after the call to xfs_rtget_summary() so that we don't end up using an illegal value of sum. Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent 6de23f8 commit 18c16f6

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

fs/xfs/xfs_rtalloc.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ xfs_rtcopy_summary(
112112
error = xfs_rtget_summary(oargs, log, bbno, &sum);
113113
if (error)
114114
goto out;
115+
if (XFS_IS_CORRUPT(oargs->mp, sum < 0)) {
116+
error = -EFSCORRUPTED;
117+
goto out;
118+
}
115119
if (sum == 0)
116120
continue;
117121
error = xfs_rtmodify_summary(oargs, log, bbno, -sum);
@@ -120,7 +124,6 @@ xfs_rtcopy_summary(
120124
error = xfs_rtmodify_summary(nargs, log, bbno, sum);
121125
if (error)
122126
goto out;
123-
ASSERT(sum > 0);
124127
}
125128
}
126129
error = 0;

0 commit comments

Comments
 (0)