Skip to content

Commit 18da820

Browse files
taniyadas20andersson
authored andcommitted
clk: qcom: gcc-glymur: Update the halt check flags for pipe clocks
The pipe clocks for PCIE and USB are externally sourced and they should not be polled by the clock driver. Update the halt_check flags to 'SKIP' to disable polling for these clocks. This helps avoid the clock status stuck at 'off' warnings, which are benign, since all consumers of the PHYs must initialize a given instance before performing any operations. Fixes: efe5043 ("clk: qcom: gcc: Add support for Global Clock Controller") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com> Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250925-glymur_gcc_usb_fixes-v2-1-ee4619571efe@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 393f783 commit 18da820

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

drivers/clk/qcom/gcc-glymur.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6760,7 +6760,7 @@ static struct clk_branch gcc_usb3_prim_phy_com_aux_clk = {
67606760

67616761
static struct clk_branch gcc_usb3_prim_phy_pipe_clk = {
67626762
.halt_reg = 0x3f088,
6763-
.halt_check = BRANCH_HALT_DELAY,
6763+
.halt_check = BRANCH_HALT_SKIP,
67646764
.hwcg_reg = 0x3f088,
67656765
.hwcg_bit = 1,
67666766
.clkr = {
@@ -6816,7 +6816,7 @@ static struct clk_branch gcc_usb3_sec_phy_com_aux_clk = {
68166816

68176817
static struct clk_branch gcc_usb3_sec_phy_pipe_clk = {
68186818
.halt_reg = 0xe2078,
6819-
.halt_check = BRANCH_HALT_VOTED,
6819+
.halt_check = BRANCH_HALT_SKIP,
68206820
.hwcg_reg = 0xe2078,
68216821
.hwcg_bit = 1,
68226822
.clkr = {
@@ -6872,7 +6872,7 @@ static struct clk_branch gcc_usb3_tert_phy_com_aux_clk = {
68726872

68736873
static struct clk_branch gcc_usb3_tert_phy_pipe_clk = {
68746874
.halt_reg = 0xe1078,
6875-
.halt_check = BRANCH_HALT_VOTED,
6875+
.halt_check = BRANCH_HALT_SKIP,
68766876
.hwcg_reg = 0xe1078,
68776877
.hwcg_bit = 1,
68786878
.clkr = {
@@ -6961,7 +6961,7 @@ static struct clk_branch gcc_usb4_0_master_clk = {
69616961

69626962
static struct clk_branch gcc_usb4_0_phy_p2rr2p_pipe_clk = {
69636963
.halt_reg = 0x2b0f4,
6964-
.halt_check = BRANCH_HALT,
6964+
.halt_check = BRANCH_HALT_SKIP,
69656965
.clkr = {
69666966
.enable_reg = 0x2b0f4,
69676967
.enable_mask = BIT(0),
@@ -6979,7 +6979,7 @@ static struct clk_branch gcc_usb4_0_phy_p2rr2p_pipe_clk = {
69796979

69806980
static struct clk_branch gcc_usb4_0_phy_pcie_pipe_clk = {
69816981
.halt_reg = 0x2b04c,
6982-
.halt_check = BRANCH_HALT_VOTED,
6982+
.halt_check = BRANCH_HALT_SKIP,
69836983
.clkr = {
69846984
.enable_reg = 0x62010,
69856985
.enable_mask = BIT(11),
@@ -7033,7 +7033,7 @@ static struct clk_branch gcc_usb4_0_phy_rx1_clk = {
70337033

70347034
static struct clk_branch gcc_usb4_0_phy_usb_pipe_clk = {
70357035
.halt_reg = 0x2b0bc,
7036-
.halt_check = BRANCH_HALT_VOTED,
7036+
.halt_check = BRANCH_HALT_SKIP,
70377037
.hwcg_reg = 0x2b0bc,
70387038
.hwcg_bit = 1,
70397039
.clkr = {
@@ -7196,7 +7196,7 @@ static struct clk_branch gcc_usb4_1_master_clk = {
71967196

71977197
static struct clk_branch gcc_usb4_1_phy_p2rr2p_pipe_clk = {
71987198
.halt_reg = 0x2d118,
7199-
.halt_check = BRANCH_HALT,
7199+
.halt_check = BRANCH_HALT_SKIP,
72007200
.clkr = {
72017201
.enable_reg = 0x2d118,
72027202
.enable_mask = BIT(0),
@@ -7214,7 +7214,7 @@ static struct clk_branch gcc_usb4_1_phy_p2rr2p_pipe_clk = {
72147214

72157215
static struct clk_branch gcc_usb4_1_phy_pcie_pipe_clk = {
72167216
.halt_reg = 0x2d04c,
7217-
.halt_check = BRANCH_HALT_VOTED,
7217+
.halt_check = BRANCH_HALT_SKIP,
72187218
.clkr = {
72197219
.enable_reg = 0x62010,
72207220
.enable_mask = BIT(12),
@@ -7268,7 +7268,7 @@ static struct clk_branch gcc_usb4_1_phy_rx1_clk = {
72687268

72697269
static struct clk_branch gcc_usb4_1_phy_usb_pipe_clk = {
72707270
.halt_reg = 0x2d0e0,
7271-
.halt_check = BRANCH_HALT_VOTED,
7271+
.halt_check = BRANCH_HALT_SKIP,
72727272
.hwcg_reg = 0x2d0e0,
72737273
.hwcg_bit = 1,
72747274
.clkr = {
@@ -7431,7 +7431,7 @@ static struct clk_branch gcc_usb4_2_master_clk = {
74317431

74327432
static struct clk_branch gcc_usb4_2_phy_p2rr2p_pipe_clk = {
74337433
.halt_reg = 0xe00f8,
7434-
.halt_check = BRANCH_HALT,
7434+
.halt_check = BRANCH_HALT_SKIP,
74357435
.clkr = {
74367436
.enable_reg = 0xe00f8,
74377437
.enable_mask = BIT(0),
@@ -7449,7 +7449,7 @@ static struct clk_branch gcc_usb4_2_phy_p2rr2p_pipe_clk = {
74497449

74507450
static struct clk_branch gcc_usb4_2_phy_pcie_pipe_clk = {
74517451
.halt_reg = 0xe004c,
7452-
.halt_check = BRANCH_HALT_VOTED,
7452+
.halt_check = BRANCH_HALT_SKIP,
74537453
.clkr = {
74547454
.enable_reg = 0x62010,
74557455
.enable_mask = BIT(13),
@@ -7503,7 +7503,7 @@ static struct clk_branch gcc_usb4_2_phy_rx1_clk = {
75037503

75047504
static struct clk_branch gcc_usb4_2_phy_usb_pipe_clk = {
75057505
.halt_reg = 0xe00c0,
7506-
.halt_check = BRANCH_HALT_VOTED,
7506+
.halt_check = BRANCH_HALT_SKIP,
75077507
.hwcg_reg = 0xe00c0,
75087508
.hwcg_bit = 1,
75097509
.clkr = {

0 commit comments

Comments
 (0)