Skip to content

Commit 191cb4e

Browse files
nsusantoalexdeucher
authored andcommitted
drm/amd/display: Underflow workaround by increasing SR exit latency
[Why] On 14us for exit latency time causes underflow for 8K monitor with HDR on. Increasing the latency to 28us fixes the underflow. [How] Increase the latency to 28us. This workaround should be sufficient before we figure out why SR exit so long. Reviewed-by: Chaitanya Dhere <chaitanya.dhere@amd.com> Acked-by: Tom Chung <chiahsuan.chung@amd.com> Signed-off-by: Nicholas Susanto <nicholas.susanto@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 39079fe commit 191cb4e

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -437,32 +437,32 @@ static struct wm_table ddr5_wm_table = {
437437
.wm_inst = WM_A,
438438
.wm_type = WM_TYPE_PSTATE_CHG,
439439
.pstate_latency_us = 11.72,
440-
.sr_exit_time_us = 14.0,
441-
.sr_enter_plus_exit_time_us = 16.0,
440+
.sr_exit_time_us = 28.0,
441+
.sr_enter_plus_exit_time_us = 30.0,
442442
.valid = true,
443443
},
444444
{
445445
.wm_inst = WM_B,
446446
.wm_type = WM_TYPE_PSTATE_CHG,
447447
.pstate_latency_us = 11.72,
448-
.sr_exit_time_us = 14.0,
449-
.sr_enter_plus_exit_time_us = 16.0,
448+
.sr_exit_time_us = 28.0,
449+
.sr_enter_plus_exit_time_us = 30.0,
450450
.valid = true,
451451
},
452452
{
453453
.wm_inst = WM_C,
454454
.wm_type = WM_TYPE_PSTATE_CHG,
455455
.pstate_latency_us = 11.72,
456-
.sr_exit_time_us = 14.0,
457-
.sr_enter_plus_exit_time_us = 16.0,
456+
.sr_exit_time_us = 28.0,
457+
.sr_enter_plus_exit_time_us = 30.0,
458458
.valid = true,
459459
},
460460
{
461461
.wm_inst = WM_D,
462462
.wm_type = WM_TYPE_PSTATE_CHG,
463463
.pstate_latency_us = 11.72,
464-
.sr_exit_time_us = 14.0,
465-
.sr_enter_plus_exit_time_us = 16.0,
464+
.sr_exit_time_us = 28.0,
465+
.sr_enter_plus_exit_time_us = 30.0,
466466
.valid = true,
467467
},
468468
}
@@ -474,32 +474,32 @@ static struct wm_table lpddr5_wm_table = {
474474
.wm_inst = WM_A,
475475
.wm_type = WM_TYPE_PSTATE_CHG,
476476
.pstate_latency_us = 11.65333,
477-
.sr_exit_time_us = 14.0,
478-
.sr_enter_plus_exit_time_us = 16.0,
477+
.sr_exit_time_us = 28.0,
478+
.sr_enter_plus_exit_time_us = 30.0,
479479
.valid = true,
480480
},
481481
{
482482
.wm_inst = WM_B,
483483
.wm_type = WM_TYPE_PSTATE_CHG,
484484
.pstate_latency_us = 11.65333,
485-
.sr_exit_time_us = 14.0,
486-
.sr_enter_plus_exit_time_us = 16.0,
485+
.sr_exit_time_us = 28.0,
486+
.sr_enter_plus_exit_time_us = 30.0,
487487
.valid = true,
488488
},
489489
{
490490
.wm_inst = WM_C,
491491
.wm_type = WM_TYPE_PSTATE_CHG,
492492
.pstate_latency_us = 11.65333,
493-
.sr_exit_time_us = 14.0,
494-
.sr_enter_plus_exit_time_us = 16.0,
493+
.sr_exit_time_us = 28.0,
494+
.sr_enter_plus_exit_time_us = 30.0,
495495
.valid = true,
496496
},
497497
{
498498
.wm_inst = WM_D,
499499
.wm_type = WM_TYPE_PSTATE_CHG,
500500
.pstate_latency_us = 11.65333,
501-
.sr_exit_time_us = 14.0,
502-
.sr_enter_plus_exit_time_us = 16.0,
501+
.sr_exit_time_us = 28.0,
502+
.sr_enter_plus_exit_time_us = 30.0,
503503
.valid = true,
504504
},
505505
}

drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_5_soc = {
164164
},
165165
},
166166
.num_states = 5,
167-
.sr_exit_time_us = 14.0,
168-
.sr_enter_plus_exit_time_us = 16.0,
167+
.sr_exit_time_us = 28.0,
168+
.sr_enter_plus_exit_time_us = 30.0,
169169
.sr_exit_z8_time_us = 210.0,
170170
.sr_enter_plus_exit_z8_time_us = 320.0,
171171
.fclk_change_latency_us = 24.0,

0 commit comments

Comments
 (0)