Input: bcm-keypad - remove unneeded NULL check before clk_disable_unprepare

Wan Jiabing · dtor · commit 1922cc9c20a3 · 2022-05-16T21:10:12.000-07:00
clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL. Remove unneeded NULL check for kp->clk. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Link: https://lore.kernel.org/r/20220516085511.10679-1-wanjiabing@vivo.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
@@ -183,8 +183,7 @@ static void bcm_kp_stop(const struct bcm_kp *kp)
 	writel(0xFFFFFFFF, kp->base + KPICR0_OFFSET);
 	writel(0xFFFFFFFF, kp->base + KPICR1_OFFSET);
 
-	if (kp->clk)
-		clk_disable_unprepare(kp->clk);
+	clk_disable_unprepare(kp->clk);
 }
 
 static int bcm_kp_open(struct input_dev *dev)

Original file line number	Diff line number	Diff line change
`@@ -183,8 +183,7 @@ static void bcm_kp_stop(const struct bcm_kp *kp)`
`183`	`183`	`writel(0xFFFFFFFF, kp->base + KPICR0_OFFSET);`
`184`	`184`	`writel(0xFFFFFFFF, kp->base + KPICR1_OFFSET);`
`185`	`185`
`186`		`- if (kp->clk)`
`187`		`- clk_disable_unprepare(kp->clk);`
	`186`	`+ clk_disable_unprepare(kp->clk);`
`188`	`187`	`}`
`189`	`188`
`190`	`189`	`static int bcm_kp_open(struct input_dev *dev)`