Skip to content

Commit 1932db2

Browse files
Sebastian Andrzej Siewioralexandrebelloni
authored andcommitted
rtc: amlogic-a4: Remove IRQF_ONESHOT
Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt can not fire (again) while its handler is running. The flag also disallows force-threading of the primary handler and the irq-core will warn about this. Remove IRQF_ONESHOT from irqflags. Fixes: c89ac91 ("rtc: support for the Amlogic on-chip RTC") Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Link: https://patch.msgid.link/20260128095540.863589-13-bigeasy@linutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent a380a02 commit 1932db2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/rtc/rtc-amlogic-a4.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ static int aml_rtc_probe(struct platform_device *pdev)
369369
return PTR_ERR(rtc->rtc_dev);
370370

371371
ret = devm_request_irq(dev, rtc->irq, aml_rtc_handler,
372-
IRQF_ONESHOT, "aml-rtc alarm", rtc);
372+
0, "aml-rtc alarm", rtc);
373373
if (ret) {
374374
dev_err_probe(dev, ret, "IRQ%d request failed, ret = %d\n",
375375
rtc->irq, ret);

0 commit comments

Comments
 (0)