Skip to content

Commit 1995f15

Browse files
tititiou36gregkh
authored andcommitted
firmware: stratix10-svc: Fix a potential resource leak in svc_create_memory_pool()
svc_create_memory_pool() is only called from stratix10_svc_drv_probe(). Most of resources in the probe are managed, but not this memremap() call. There is also no memunmap() call in the file. So switch to devm_memremap() to avoid a resource leak. Cc: stable@vger.kernel.org Fixes: 7ca5ce8 ("firmware: add Intel Stratix10 service layer driver") Link: https://lore.kernel.org/all/783e9dfbba34e28505c9efa8bba41f97fd0fa1dc.1686109400.git.christophe.jaillet@wanadoo.fr/ Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> Message-ID: <20230613211521.16366-1-dinguyen@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 09dd7b9 commit 1995f15

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/firmware/stratix10-svc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ svc_create_memory_pool(struct platform_device *pdev,
755755
end = rounddown(sh_memory->addr + sh_memory->size, PAGE_SIZE);
756756
paddr = begin;
757757
size = end - begin;
758-
va = memremap(paddr, size, MEMREMAP_WC);
758+
va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
759759
if (!va) {
760760
dev_err(dev, "fail to remap shared memory\n");
761761
return ERR_PTR(-EINVAL);

0 commit comments

Comments
 (0)