Skip to content

Commit 19ac990

Browse files
jonhuntergregkh
authored andcommitted
usb: gadget: u_ether: Don't warn in gether_setup_name_default()
The function gether_setup_name_default() is called by various USB ethernet gadget drivers. Calling this function will select a random host and device MAC addresses. A properly working driver should be silent and not warn the user about default MAC addresses selection. Given that the MAC addresses are also printed when the function gether_register_netdev() is called, remove these unnecessary warnings. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com> Link: https://lore.kernel.org/r/20230209125319.18589-2-jonathanh@nvidia.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 938fc64 commit 19ac990

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/usb/gadget/function/u_ether.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -812,13 +812,11 @@ struct net_device *gether_setup_name_default(const char *netname)
812812
snprintf(net->name, sizeof(net->name), "%s%%d", netname);
813813

814814
eth_random_addr(dev->dev_mac);
815-
pr_warn("using random %s ethernet address\n", "self");
816815

817816
/* by default we always have a random MAC address */
818817
net->addr_assign_type = NET_ADDR_RANDOM;
819818

820819
eth_random_addr(dev->host_mac);
821-
pr_warn("using random %s ethernet address\n", "host");
822820

823821
net->netdev_ops = &eth_netdev_ops;
824822

0 commit comments

Comments
 (0)