Skip to content

Commit 19d340a

Browse files
thejhaxboe
authored andcommitted
io_uring/rsrc: require cloned buffers to share accounting contexts
When IORING_REGISTER_CLONE_BUFFERS is used to clone buffers from uring instance A to uring instance B, where A and B use different MMs for accounting, the accounting can go wrong: If uring instance A is closed before uring instance B, the pinned memory counters for uring instance B will be decremented, even though the pinned memory was originally accounted through uring instance A; so the MM of uring instance B can end up with negative locked memory. Cc: stable@vger.kernel.org Closes: https://lore.kernel.org/r/CAG48ez1zez4bdhmeGLEFxtbFADY4Czn3CV0u9d_TMcbvRA01bg@mail.gmail.com Fixes: 7cc2a6e ("io_uring: add IORING_REGISTER_COPY_BUFFERS method") Signed-off-by: Jann Horn <jannh@google.com> Link: https://lore.kernel.org/r/20250114-uring-check-accounting-v1-1-42e4145aa743@google.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent a13030f commit 19d340a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

io_uring/rsrc.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -928,6 +928,13 @@ static int io_clone_buffers(struct io_ring_ctx *ctx, struct io_ring_ctx *src_ctx
928928
int i, ret, off, nr;
929929
unsigned int nbufs;
930930

931+
/*
932+
* Accounting state is shared between the two rings; that only works if
933+
* both rings are accounted towards the same counters.
934+
*/
935+
if (ctx->user != src_ctx->user || ctx->mm_account != src_ctx->mm_account)
936+
return -EINVAL;
937+
931938
/* if offsets are given, must have nr specified too */
932939
if (!arg->nr && (arg->dst_off || arg->src_off))
933940
return -EINVAL;

0 commit comments

Comments
 (0)