Skip to content

Commit 19e65c4

Browse files
WhiteFox-Projectkuba-moo
authored andcommitted
net: davicom: fix UAF in dm9000_drv_remove
dm is netdev private data and it cannot be used after free_netdev() call. Using dm after free_netdev() can cause UAF bug. Fix it by moving free_netdev() at the end of the function. This is similar to the issue fixed in commit ad297cd ("net: qcom/emac: fix UAF in emac_remove"). This bug is detected by our static analysis tool. Fixes: cf9e60a ("net: davicom: Fix regulator not turned off on driver removal") Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com> CC: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Link: https://patch.msgid.link/20250123214213.623518-1-chenyuan0y@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent bd1bbab commit 19e65c4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/ethernet/davicom/dm9000.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1777,10 +1777,11 @@ static void dm9000_drv_remove(struct platform_device *pdev)
17771777

17781778
unregister_netdev(ndev);
17791779
dm9000_release_board(pdev, dm);
1780-
free_netdev(ndev); /* free device structure */
17811780
if (dm->power_supply)
17821781
regulator_disable(dm->power_supply);
17831782

1783+
free_netdev(ndev); /* free device structure */
1784+
17841785
dev_dbg(&pdev->dev, "released and freed device\n");
17851786
}
17861787

0 commit comments

Comments
 (0)