Skip to content

Commit 1a1ce78

Browse files
openedevdaeinki
authored andcommitted
drm: exynos: dsi: Restore proper bridge chain order
Restore the proper bridge chain by finding the previous bridge in the chain instead of passing NULL. This establishes a proper bridge chain while attaching downstream bridges. Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> Signed-off-by: Inki Dae <inki.dae@samsung.com>
1 parent 4aa5fc8 commit 1a1ce78

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

drivers/gpu/drm/exynos/exynos_drm_dsi.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1445,7 +1445,8 @@ static int exynos_dsi_attach(struct drm_bridge *bridge,
14451445
{
14461446
struct exynos_dsi *dsi = bridge_to_dsi(bridge);
14471447

1448-
return drm_bridge_attach(bridge->encoder, dsi->out_bridge, NULL, flags);
1448+
return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge,
1449+
flags);
14491450
}
14501451

14511452
static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
@@ -1491,7 +1492,10 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
14911492

14921493
drm_bridge_add(&dsi->bridge);
14931494

1494-
drm_bridge_attach(encoder, &dsi->bridge, NULL, 0);
1495+
drm_bridge_attach(encoder, &dsi->bridge,
1496+
list_first_entry_or_null(&encoder->bridge_chain,
1497+
struct drm_bridge,
1498+
chain_node), 0);
14951499

14961500
/*
14971501
* This is a temporary solution and should be made by more generic way.
@@ -1726,6 +1730,7 @@ static int exynos_dsi_probe(struct platform_device *pdev)
17261730
dsi->bridge.funcs = &exynos_dsi_bridge_funcs;
17271731
dsi->bridge.of_node = dev->of_node;
17281732
dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
1733+
dsi->bridge.pre_enable_prev_first = true;
17291734

17301735
ret = component_add(dev, &exynos_dsi_component_ops);
17311736
if (ret)

0 commit comments

Comments
 (0)