Skip to content

Commit 1a70ca7

Browse files
konradybcioGeorgi Djakov
authored andcommitted
interconnect: qcom: bcm-voter: Use enable_maks for keepalive voting
BCMs with an enable_mask expect to only have that specific value written to them. The current implementation only works by miracle for BCMs with enable mask == BIT(0), as the minimal vote we've been using so far just so happens to be equal to that. Use the correct value with keepalive voting. Fixes: d8630f0 ("interconnect: qcom: Add support for mask-based BCMs") Reported-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20230811-topic-icc_fix_1he-v2-2-0620af8ac133@linaro.org Signed-off-by: Georgi Djakov <djakov@kernel.org>
1 parent a1f4170 commit 1a70ca7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/interconnect/qcom/bcm-voter.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ static void bcm_aggregate_mask(struct qcom_icc_bcm *bcm)
8181
}
8282

8383
if (bcm->keepalive) {
84-
bcm->vote_x[QCOM_ICC_BUCKET_AMC] = 1;
85-
bcm->vote_x[QCOM_ICC_BUCKET_WAKE] = 1;
86-
bcm->vote_y[QCOM_ICC_BUCKET_AMC] = 1;
87-
bcm->vote_y[QCOM_ICC_BUCKET_WAKE] = 1;
84+
bcm->vote_x[QCOM_ICC_BUCKET_AMC] = bcm->enable_mask;
85+
bcm->vote_x[QCOM_ICC_BUCKET_WAKE] = bcm->enable_mask;
86+
bcm->vote_y[QCOM_ICC_BUCKET_AMC] = bcm->enable_mask;
87+
bcm->vote_y[QCOM_ICC_BUCKET_WAKE] = bcm->enable_mask;
8888
}
8989
}
9090

0 commit comments

Comments
 (0)