Skip to content

Commit 1aa8df9

Browse files
keesTzung-Bi Shih
authored andcommitted
platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct ec_event_queue. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Benson Leung <bleung@chromium.org> Cc: Tzung-Bi Shih <tzungbi@kernel.org> Cc: Dawei Li <set_pte_at@outlook.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Maximilian Luz <luzmaximilian@gmail.com> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiang Jian <jiangjian@cdjrlc.com> Cc: chrome-platform@lists.linux.dev Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20230922175146.work.219-kees@kernel.org Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
1 parent 0bb80ec commit 1aa8df9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/platform/chrome/wilco_ec

drivers/platform/chrome/wilco_ec/event.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ struct ec_event_queue {
9595
int capacity;
9696
int head;
9797
int tail;
98-
struct ec_event *entries[];
98+
struct ec_event *entries[] __counted_by(capacity);
9999
};
100100

101101
/* Maximum number of events to store in ec_event_queue */

0 commit comments

Comments
 (0)