ceph: assign the ci only when the inode isn't NULL

lxbsz · idryomov · commit 1ad3bb28d336 · 2022-03-21T13:35:16.000+01:00
The ceph_find_inode() may will fail and return NULL.

Signed-off-by: Xiubo Li &lt;xiubli@redhat.com&gt;
Reviewed-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Signed-off-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
@@ -4166,7 +4166,6 @@ void ceph_handle_caps(struct ceph_mds_session *session,
 
 	/* lookup ino */
 	inode = ceph_find_inode(mdsc->fsc->sb, vino);
-	ci = ceph_inode(inode);
 	dout(" op %s ino %llx.%llx inode %p\n", ceph_cap_op_name(op), vino.ino,
 	     vino.snap, inode);
 
@@ -4192,6 +4191,7 @@ void ceph_handle_caps(struct ceph_mds_session *session,
 		}
 		goto flush_cap_releases;
 	}
+	ci = ceph_inode(inode);
 
 	/* these will work even if we don't have a cap yet */
 	switch (op) {

Original file line number	Diff line number	Diff line change
`@@ -4166,7 +4166,6 @@ void ceph_handle_caps(struct ceph_mds_session *session,`
`4166`	`4166`
`4167`	`4167`	`/* lookup ino */`
`4168`	`4168`	`inode = ceph_find_inode(mdsc->fsc->sb, vino);`
`4169`		`- ci = ceph_inode(inode);`
`4170`	`4169`	`dout(" op %s ino %llx.%llx inode %p\n", ceph_cap_op_name(op), vino.ino,`
`4171`	`4170`	`vino.snap, inode);`
`4172`	`4171`
`@@ -4192,6 +4191,7 @@ void ceph_handle_caps(struct ceph_mds_session *session,`
`4192`	`4191`	`}`
`4193`	`4192`	`goto flush_cap_releases;`
`4194`	`4193`	`}`
	`4194`	`+ ci = ceph_inode(inode);`
`4195`	`4195`
`4196`	`4196`	`/* these will work even if we don't have a cap yet */`
`4197`	`4197`	`switch (op) {`