Skip to content

Commit 1affd29

Browse files
Sebastian Andrzej SiewiorThomas Gleixner
authored andcommitted
char: tpm: cr50: Remove IRQF_ONESHOT
Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt can not fire (again) while its handler is running. The flag also prevents force-threading of the primary handler and the irq-core will warn about this. Remove IRQF_ONESHOT from irqflags. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Link: https://patch.msgid.link/20260128095540.863589-10-bigeasy@linutronix.de
1 parent a82bf78 commit 1affd29

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/char/tpm/tpm_tis_i2c_cr50.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -749,8 +749,7 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
749749

750750
if (client->irq > 0) {
751751
rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
752-
IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
753-
IRQF_NO_AUTOEN,
752+
IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
754753
dev->driver->name, chip);
755754
if (rc < 0) {
756755
dev_err(dev, "Failed to probe IRQ %d\n", client->irq);

drivers/char/tpm/tpm_tis_spi_cr50.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ int cr50_spi_probe(struct spi_device *spi)
287287
if (spi->irq > 0) {
288288
ret = devm_request_irq(&spi->dev, spi->irq,
289289
cr50_spi_irq_handler,
290-
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
290+
IRQF_TRIGGER_RISING,
291291
"cr50_spi", cr50_phy);
292292
if (ret < 0) {
293293
if (ret == -EPROBE_DEFER)

0 commit comments

Comments
 (0)