Skip to content

Commit 1b5ea7f

Browse files
ffainellikuba-moo
authored andcommitted
net: bcmgenet: Ensure MDIO unregistration has clocks enabled
With support for Ethernet PHY LEDs having been added, while unregistering a MDIO bus and its child device liks PHYs there may be "late" accesses to the MDIO bus. One typical use case is setting the PHY LEDs brightness to OFF for instance. We need to ensure that the MDIO bus controller remains entirely functional since it runs off the main GENET adapter clock. Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/20230617155500.4005881-1-andrew@lunn.ch/ Fixes: 9a4e796 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver") Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20230622103107.1760280-1-florian.fainelli@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 6f68fc3 commit 1b5ea7f

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • drivers/net/ethernet/broadcom/genet

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,5 +673,7 @@ void bcmgenet_mii_exit(struct net_device *dev)
673673
if (of_phy_is_fixed_link(dn))
674674
of_phy_deregister_fixed_link(dn);
675675
of_node_put(priv->phy_dn);
676+
clk_prepare_enable(priv->clk);
676677
platform_device_unregister(priv->mii_pdev);
678+
clk_disable_unprepare(priv->clk);
677679
}

0 commit comments

Comments
 (0)