Skip to content

Commit 1b9855d

Browse files
Sebastian Andrzej SiewiorKAGA-KOKO
authored andcommitted
misc: hi6421-spmi-pmic: Use generic_handle_irq_safe().
generic_handle_irq() is invoked from a regular interrupt service routine. This handler will become a forced-threaded handler on PREEMPT_RT and will be invoked with enabled interrupts. The generic_handle_irq() must be invoked with disabled interrupts in order to avoid deadlocks. Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20220211181500.1856198-5-bigeasy@linutronix.de
1 parent d2206fc commit 1b9855d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/misc/hi6421v600-irq.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ static irqreturn_t hi6421v600_irq_handler(int irq, void *__priv)
117117
* If both powerkey down and up IRQs are received,
118118
* handle them at the right order
119119
*/
120-
generic_handle_irq(priv->irqs[POWERKEY_DOWN]);
121-
generic_handle_irq(priv->irqs[POWERKEY_UP]);
120+
generic_handle_irq_safe(priv->irqs[POWERKEY_DOWN]);
121+
generic_handle_irq_safe(priv->irqs[POWERKEY_UP]);
122122
pending &= ~HISI_IRQ_POWERKEY_UP_DOWN;
123123
}
124124

125125
if (!pending)
126126
continue;
127127

128128
for_each_set_bit(offset, &pending, BITS_PER_BYTE) {
129-
generic_handle_irq(priv->irqs[offset + i * BITS_PER_BYTE]);
129+
generic_handle_irq_safe(priv->irqs[offset + i * BITS_PER_BYTE]);
130130
}
131131
}
132132

0 commit comments

Comments
 (0)