Skip to content

Commit 1c19601

Browse files
Srinivasa Rao Mandadapubroonie
authored andcommitted
ASoC: codecs: Fix misplaced lpass_macro_pds_exit call
Update power domains exit function calling from runtime resume to remove function which was wrongly placed and causing crash in device suspend and resume. Fixes: 9e3d83c ("ASoC: codecs: Add power domains support in digital macro codecs") Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> Link: https://lore.kernel.org/r/1647355531-4150-1-git-send-email-quic_srivasam@quicinc.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 455c565 commit 1c19601

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

sound/soc/codecs/lpass-tx-macro.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,6 +1920,8 @@ static int tx_macro_remove(struct platform_device *pdev)
19201920
clk_disable_unprepare(tx->npl);
19211921
clk_disable_unprepare(tx->fsgen);
19221922

1923+
lpass_macro_pds_exit(tx->pds);
1924+
19231925
return 0;
19241926
}
19251927

@@ -1964,8 +1966,6 @@ static int __maybe_unused tx_macro_runtime_resume(struct device *dev)
19641966
regcache_sync(tx->regmap);
19651967
tx->reset_swr = true;
19661968

1967-
lpass_macro_pds_exit(tx->pds);
1968-
19691969
return 0;
19701970
err_fsgen:
19711971
clk_disable_unprepare(tx->npl);

sound/soc/codecs/lpass-va-macro.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1503,6 +1503,8 @@ static int va_macro_remove(struct platform_device *pdev)
15031503
clk_disable_unprepare(va->dcodec);
15041504
clk_disable_unprepare(va->macro);
15051505

1506+
lpass_macro_pds_exit(va->pds);
1507+
15061508
return 0;
15071509
}
15081510

@@ -1532,8 +1534,6 @@ static int __maybe_unused va_macro_runtime_resume(struct device *dev)
15321534
regcache_cache_only(va->regmap, false);
15331535
regcache_sync(va->regmap);
15341536

1535-
lpass_macro_pds_exit(va->pds);
1536-
15371537
return 0;
15381538
}
15391539

0 commit comments

Comments
 (0)