mtd: rawnand: atmel: Warn about failure to unregister mtd device

Uwe Kleine-König · miquelraynal · commit 1cc82e09fc20 · 2022-06-09T15:06:31.000+02:00
The Linux device core doesn't intend remove callbacks to fail. If an error code is returned the device is removed anyhow. So wail loudly if the atmel specific remove callback fails and return 0 anyhow to suppress the generic (and little helpful) error message by the device core. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20220607062503.211345-1-u.kleine-koenig@pengutronix.de
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -2629,7 +2629,9 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
 {
 	struct atmel_nand_controller *nc = platform_get_drvdata(pdev);
 
-	return nc->caps->ops->remove(nc);
+	WARN_ON(nc->caps->ops->remove(nc));
+
+	return 0;
 }
 
 static __maybe_unused int atmel_nand_controller_resume(struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -2629,7 +2629,9 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)`
`2629`	`2629`	`{`
`2630`	`2630`	`struct atmel_nand_controller *nc = platform_get_drvdata(pdev);`
`2631`	`2631`
`2632`		`- return nc->caps->ops->remove(nc);`
	`2632`	`+ WARN_ON(nc->caps->ops->remove(nc));`
	`2633`	`+`
	`2634`	`+ return 0;`
`2633`	`2635`	`}`
`2634`	`2636`
`2635`	`2637`	`static __maybe_unused int atmel_nand_controller_resume(struct device *dev)`