Skip to content

Commit 1ccfd1a

Browse files
committed
firewire: core: arrangement header inclusion for tracepoints events
It is a bit inconvenient to put the relative path to local header from tree-wide header. This commit delegates the selection to include headers into users. Link: https://lore.kernel.org/r/20240605235155.116468-11-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
1 parent f9a2283 commit 1ccfd1a

4 files changed

Lines changed: 7 additions & 2 deletions

File tree

drivers/firewire/core-trace.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
// SPDX-License-Identifier: GPL-2.0-or-later
22
// Copyright (c) 2024 Takashi Sakamoto
33

4+
#include <linux/types.h>
5+
#include "packet-header-definitions.h"
6+
47
#define CREATE_TRACE_POINTS
58
#include <trace/events/firewire.h>

drivers/firewire/core-transaction.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
#include <asm/byteorder.h>
3030

3131
#include "core.h"
32-
#include <trace/events/firewire.h>
3332
#include "packet-header-definitions.h"
33+
#include <trace/events/firewire.h>
3434

3535
#define HEADER_DESTINATION_IS_BROADCAST(header) \
3636
((async_header_get_destination(header) & 0x3f) == 0x3f)

drivers/firewire/packet-header-definitions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
#ifndef _FIREWIRE_PACKET_HEADER_DEFINITIONS_H
88
#define _FIREWIRE_PACKET_HEADER_DEFINITIONS_H
99

10+
#include <linux/types.h>
11+
1012
#define ASYNC_HEADER_QUADLET_COUNT 4
1113

1214
#define ASYNC_HEADER_Q0_DESTINATION_SHIFT 16

include/trace/events/firewire.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
#include <linux/firewire-constants.h>
1313

14-
#include "../../../drivers/firewire/packet-header-definitions.h"
14+
// Some macros are defined in 'drivers/firewire/packet-header-definitions.h'.
1515

1616
// The content of TP_printk field is preprocessed, then put to the module binary.
1717
#define ASYNC_HEADER_GET_DESTINATION(header) \

0 commit comments

Comments
 (0)