NFSv4.1: don't retry BIND_CONN_TO_SESSION on session error

olgakorn1 · Trond Myklebust · commit 1d15d121cc2a · 2022-03-24T12:06:07.000-04:00
There is no reason to retry the operation if a session error had occurred in such case result structure isn't filled out. Fixes: dff5853 ("NFSv4.1: fix handling of backchannel binding in BIND_CONN_TO_SESSION") Signed-off-by: Olga Kornievskaia <kolga@netapp.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
@@ -8340,6 +8340,7 @@ nfs4_bind_one_conn_to_session_done(struct rpc_task *task, void *calldata)
 	case -NFS4ERR_DEADSESSION:
 		nfs4_schedule_session_recovery(clp->cl_session,
 				task->tk_status);
+		return;
 	}
 	if (args->dir == NFS4_CDFC4_FORE_OR_BOTH &&
 			res->dir != NFS4_CDFS4_BOTH) {

Original file line number	Diff line number	Diff line change
`@@ -8340,6 +8340,7 @@ nfs4_bind_one_conn_to_session_done(struct rpc_task task, void calldata)`
`8340`	`8340`	`case -NFS4ERR_DEADSESSION:`
`8341`	`8341`	`nfs4_schedule_session_recovery(clp->cl_session,`
`8342`	`8342`	`task->tk_status);`
	`8343`	`+ return;`
`8343`	`8344`	`}`
`8344`	`8345`	`if (args->dir == NFS4_CDFC4_FORE_OR_BOTH &&`
`8345`	`8346`	`res->dir != NFS4_CDFS4_BOTH) {`