Skip to content

Commit 1d20e5d

Browse files
ZhongqiuHan-Qcompalmer-dabbelt
authored andcommitted
riscv: signal: Remove unlikely() from WARN_ON() condition
"WARN_ON(unlikely(x))" is excessive. WARN_ON() already uses unlikely() internally. Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Andy Chiu <andy.chiu@sifive.com> Link: https://lore.kernel.org/r/20240620033434.3778156-1-quic_zhonhan@quicinc.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1 parent 5d5fc33 commit 1d20e5d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/riscv/kernel/signal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static long save_v_state(struct pt_regs *regs, void __user **sc_vec)
8484
datap = state + 1;
8585

8686
/* datap is designed to be 16 byte aligned for better performance */
87-
WARN_ON(unlikely(!IS_ALIGNED((unsigned long)datap, 16)));
87+
WARN_ON(!IS_ALIGNED((unsigned long)datap, 16));
8888

8989
get_cpu_vector_context();
9090
riscv_v_vstate_save(&current->thread.vstate, regs);

0 commit comments

Comments
 (0)