Skip to content

Commit 1d43ddd

Browse files
JoseExpositoFomys
authored andcommitted
drm/vkms: Drop unnecessary call to drm_crtc_cleanup()
CRTC creation uses drmm_crtc_init_with_planes(), which automatically handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is still present in the vkms_output_init() error path. Fixes: 99cc528 ("drm/vkms: Use drmm_crtc_init_with_planes()") Signed-off-by: José Expósito <jose.exposito89@gmail.com> Reviewed-by: Maíra Canal <mcanal@igalia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241031183835.3633-1-jose.exposito89@gmail.com Acked-by: Louis Chauvet <louis.chauvet@bootlin.com> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
1 parent 89115ae commit 1d43ddd

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/gpu/drm/vkms/vkms_output.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index)
9292
DRM_MODE_CONNECTOR_VIRTUAL);
9393
if (ret) {
9494
DRM_ERROR("Failed to init connector\n");
95-
goto err_connector;
95+
return ret;
9696
}
9797

9898
drm_connector_helper_add(connector, &vkms_conn_helper_funcs);
@@ -131,8 +131,5 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index)
131131
err_encoder:
132132
drm_connector_cleanup(connector);
133133

134-
err_connector:
135-
drm_crtc_cleanup(crtc);
136-
137134
return ret;
138135
}

0 commit comments

Comments
 (0)