Skip to content

Commit 1f3dc29

Browse files
committed
iommu/arm-smmu-v3: Add missing #include of linux/string_choices.h
Commit f2c77f6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") introduced a call to str_read_write() in the SMMUv3 driver but without an explicit #include of <linux/string_choices.h>. This breaks the build for custom configurations where CONFIG_ACPI=n: drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1909:4: error: call to undeclared function 'str_read_write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 1909 | str_read_write(evt->read), | ^ Add the missing #include. Link: https://lore.kernel.org/r/d07e82a4-2880-4ae3-961b-471bfa7ac6c4@samsung.com Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Fixes: f2c77f6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") Signed-off-by: Will Deacon <will@kernel.org>
1 parent f2c77f6 commit 1f3dc29

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include <linux/pci.h>
2727
#include <linux/pci-ats.h>
2828
#include <linux/platform_device.h>
29+
#include <linux/string_choices.h>
2930
#include <kunit/visibility.h>
3031
#include <uapi/linux/iommufd.h>
3132

0 commit comments

Comments
 (0)